Skip to content

fix: getBoundingClientRect undefined check #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: getBoundingClientRect undefined check #2496

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6239b6b
fix: getBoundingClientRect null check
pinpong Sep 23, 2025
e70fa90
Update package.json
pinpong Sep 25, 2025
a30569b
Update useBoundingClientRect.ts
pinpong Sep 25, 2025
26eb23e
Update useBoundingClientRect.ts
pinpong Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useBoundingClientRect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ export function useBoundingClientRect(
}

// @ts-ignore 👉 https://github.com/facebook/react/commit/53b1f69ba
if (ref.current.unstable_getBoundingClientRect !== null) {
if (ref.current.unstable_getBoundingClientRect != null) {
// @ts-ignore https://github.com/facebook/react/commit/53b1f69ba
const layout = ref.current.unstable_getBoundingClientRect();
handler(layout);
return;
}

// @ts-ignore once it `unstable_getBoundingClientRect` gets stable 🤞.
if (ref.current.getBoundingClientRect !== null) {
if (ref.current.getBoundingClientRect != null) {
// @ts-ignore once it `unstable_getBoundingClientRect` gets stable.
const layout = ref.current.getBoundingClientRect();
handler(layout);
Expand Down