Skip to content

Conversation

@garethgeorge
Copy link

Untested implementation that expands libium's heuristic for github releases to capture the common pattern of mod version in the release name with a single associated jar. For an example see Cow's odd widgets.

The heuristic implemented is:

  • If there are multiple .jar assets, check for a version in the asset name.
  • If there is a single .jar asset, check version in the asset name and fallback to the release name.

This code compiles, but I'm looking for guidance on testing pattern for libium as I'm not seeing tests in the repository and ran into some issues when trying to build ferium with a local copy.

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants