Skip to content

Commit

Permalink
Version bump to 0.3.1
Browse files Browse the repository at this point in the history
- Remove unnecessary EOL on _computeUrl return statement
- Add github version badge
- Update bower version badge
- Add Published on webcomponents.org badge
  • Loading branch information
gorlandor committed Mar 1, 2017
1 parent b3cd262 commit a5e9163
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 19 deletions.
21 changes: 5 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,10 @@ A Polymer custom element that fetches movie, series, episode data from the

# Change Log

Version: 0.3.0
- Update bower dependencies
- Update box-sizing to border-box
- Update element styles to use flex-box
- Move url and computeUrl to the Private API
- Add baseUrl property
- Add reflectToAttribute prop to q, year, type, page, and apiVersion
- Add on-error event listener; should an error occurs when loading an image, it will set the default img instead
- Set the li tag id property to the imdbID value
- Set the anchor tag href property to the hash imdbID value
- Remove bootstrap dependency from demo
- Update demo styles
Version: 0.3.1
- Remove unnecessary EOL on _computeUrl return statement
- Add github version badge
- Add github license badge
- Add bower version badge
- Update bower version badge
- Add Published on webcomponents.org badge

# Demo it
Expand All @@ -48,7 +37,7 @@ In that index.html add the following code:

```html
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>OMDb Search demo</title>
Expand All @@ -68,7 +57,7 @@ In that index.html add the following code:
</body>
</html>
```
# Available on [webcomponents.org](https://www.webcomponents.org/element/giovanni0918/omdb-search) and [customelements.io](https://customelements.io/giovanni0918/omdb-search/)
# Available on [webcomponents.org](https://www.webcomponents.org/element/giovanni0918/omdb-search)

# License
Mit: <https://mit-license.org/>
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "omdb-search",
"version": "0.3.0",
"version": "0.3.1",
"authors": [
"Giovanni Orlando Rivera <gorlandor@gmail.com>"
],
Expand Down
3 changes: 1 addition & 2 deletions omdb-search.html
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,7 @@ <h4 class="result__heading">{{item.Title}}
* Computes and returns the request Url from the
* user assigned element props. */
_computeUrl: function (baseUrl, q, type, year, responseType, page, apiVersion) {
return `${baseUrl}/?s=${q.replace(/^\s+|\s+$/g, '')}&type=${type}&y=${year}
&r=${responseType}'&page=${page}&v=${apiVersion}`;
return `${baseUrl}/?s=${q.replace(/^\s+|\s+$/g, '')}&type=${type}&y=${year}&r=${responseType}'&page=${page}&v=${apiVersion}`;
},
/**
* Checks if the image source value received as input is valid,
Expand Down

0 comments on commit a5e9163

Please sign in to comment.