Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets relative paths, fixes lets-encrypt cert resolver, env references #30

Closed
wants to merge 0 commits into from
Closed

Sets relative paths, fixes lets-encrypt cert resolver, env references #30

wants to merge 0 commits into from

Conversation

rwc
Copy link

@rwc rwc commented Nov 30, 2021

This PR:

@fleischsalatinspace
Copy link
Collaborator

Sorry @rwc totally missed this one. Will have a look at it

@rwc
Copy link
Author

rwc commented Jan 11, 2022

@fleischsalatinspace No problem, let me know if you want to pair on it/talk about changes.

@steven-cmy steven-cmy mentioned this pull request Jan 14, 2022
pf-redis:
image: redis:6.2.5-alpine3.14
container_name: "$CONTAINER_NAME-redis"
container_name: "{$CONTAINER_NAME}-redis"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be container_name: "${CONTAINER_NAME}-redis"

@samoneilll
Copy link
Contributor

Hi All,

Apologies about the delay. Tyr is making a bunch of changes that I believe will resolve this. If not we'll review again later in Feb.

@rwc rwc closed this Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Convert absolute paths for mounts in docker-compose.yml to relative paths
4 participants