Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing altering pre-publish-hook and revert last test #17

Merged
merged 2 commits into from
Oct 10, 2024
Merged

testing altering pre-publish-hook and revert last test #17

merged 2 commits into from
Oct 10, 2024

Conversation

rkeur7
Copy link
Contributor

@rkeur7 rkeur7 commented Oct 10, 2024 •
edited
Loading

Jira Ticket: https://shippo.atlassian.net/browse/CET-317

Description:
Change in this PR that resulted in 2 ItemGroups compared to old versions having 1 ItemGroup surfaced this error (screenshot below):
Screenshot 2024-10-10 at 2 37 05 PM

Testing:

  • Captured last known working version of Shippo/Shippo.csproj --> tested existing pre-publish-hook script (specifically yq portion).
  • Replicated but with current version of Shippo/Shippo.csproj
  • Altered yq portion of script based on having 2 ItemGroups (array) compared to original version with 1 ItemGroup.
  • Compared versions that were created from yq and show similar formatting for result ItemGroups. (see screenshot below, current (left) vs old copy (right))
    Screenshot 2024-10-10 at 2 41 47 PM

@rkeur7
update based on local testing, root cause of error is 2 sets of ItemG…
9e47f3c 
…roups, root for why that was generated is tbd still
@rkeur7 rkeur7 merged commit a77d4fc into main Oct 10, 2024
1 check passed
@rkeur7 rkeur7 deleted the bug/cet-317 branch October 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmrebughini malcolmrebughini malcolmrebughini approved these changes

@AdrianCollinsShippo AdrianCollinsShippo Awaiting requested review from AdrianCollinsShippo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkeur7 @malcolmrebughini