Skip to content

feat(core,track): move gosling-theme to this repo, support more compact genomic axis style #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 4, 2023

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Nov 23, 2023

Fix #990
Fix #860

Change List

(Changes after moving the gosling-theme repo can be found at 7d5fd40...d924a9d)

labelMargin

The margin around labels for calculating visual overlaps between labels. This is mainly used for determining the visibility of axis labels. 0 if no margin to use. Negative values (-1) for showing all labels even if they overlap.

labelExcludeChrPrefix

If true, labels of genomics axes excludes the chromosome prefix (e.g., chr1 -> 1).

Screenshots

Default (labelMargin == 5, labelExcludeChrPrefix == false)

gosling-visualization (3)

labelMargin == 0, labelExcludeChrPrefix == false

gosling-visualization (2)

labelMargin == -1, labelExcludeChrPrefix == false

gosling-visualization (1)

labelMargin == -1, labelExcludeChrPrefix == true

gosling-visualization

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi changed the title "feat(core,track): move gosling-theme to this repo, support more compact genomic axis" feat(core,track): move gosling-theme to this repo, support more compact genomic axis Nov 23, 2023
@sehilyi sehilyi changed the title feat(core,track): move gosling-theme to this repo, support more compact genomic axis feat(core,track): move gosling-theme to this repo, support more compact genomic axis style Nov 29, 2023
@sehilyi sehilyi requested a review from etowahadams November 29, 2023 15:28
@thomcsmits
Copy link
Collaborator

Very nice! Two things:

  • I don't think the labelMargin is very intuitive, so we need to add good documentation for this
  • When two labels are too overlapping, then the second is hidden (I suppose?), but I can imagine users want to specify specifically the labels they want to show (for e.g. figure for paper), perhaps we should also add this option

Copy link
Contributor

@etowahadams etowahadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Glad to have the gosling themes moved to this repo.
Once this gets merged into master, I'll copy over the schema into the gosling-website and update the docs

@sehilyi sehilyi merged commit 09c0179 into master Dec 4, 2023
@sehilyi sehilyi deleted the sehilyi/gosling-theme branch December 4, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genomic axis hides chr<N> labels Include gosling-lang/gosling-theme to this repo
3 participants