-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: MGM mode for magma/kuznyechik cipher. Initial implementation. #393
base: master
Are you sure you want to change the base?
Conversation
first implemented in ossl_patched branch
What is the best choice to add identifiers? |
I have applied this changes on my local computer. And it seems that all built in tests is passed through. |
This is my local changes to OpenSSL: |
Sorry for the delay. The big idea is
After that it becomes possible to add support of ciphersuites to openssl. |
ok. thanks. |
In theory, you could dynamically register NIDs for them. In practice I don't see much sense, so let's leave it in provider part only. |
so, no internal tests for engine, only for provider case? |
yes. You should write the C test loading the provider, fetching an algorithm and performing test. |
To make tests pass through we need to update OpenSSL's objects.txt file with new identifiers: