Skip to content

Handle secondary address in InstrumentAddress and add two options #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle secondary address in InstrumentAddress and add two options #2

wants to merge 3 commits into from

Conversation

mpictor
Copy link

@mpictor mpictor commented Sep 16, 2025

Let me know if you would prefer these 3 commits to be separate PRs.

  • WithAR488 option: compatibility with the Arduino-based AR488
    • This adjusts the init command sequence to play nicely with the AR488.
  • WithDebug option: log commands and responses
  • InstrumentAddress: handle secondary address
    • Note that two "soft" errors are introduced to report an internal state mismatch (configured vs reported address). Let me know if you'd prefer to ignore them or handle them differently.
    • In addition, this fixes a couple typos in the DS345 example.

@mpictor
Copy link
Author

mpictor commented Sep 24, 2025

@matthewrankin any thoughts on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpictor