fix: unhandled parse BQ table FQN (#42)

Handle panic error due to invalid fqn
goto · Nov 15, 2023 · 03d709b · 03d709b
1 parent 7e91ad5
commit 03d709b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/plugins/util.go b/plugins/util.go
@@ -145,5 +145,10 @@ func parseBQTableFQN(fqn string) (projectID, datasetID, tableID string, err erro
 	ss := strings.FieldsFunc(fqn, func(r rune) bool {
 		return r == ':' || r == '.'
 	})
+	if len(ss) < 3 {
+		return "", "", "", fmt.Errorf(
+			"unexpected BigQuery table FQN '%s', expected in format projectID:datasetID.tableID", fqn,
+		)
+	}
 	return ss[0], ss[1], ss[2], nil
 }
diff --git a/plugins/util_test.go b/plugins/util_test.go
@@ -41,6 +41,11 @@ func TestBigQueryTableFQNToURN(t *testing.T) {
 			fqn:         "bq-raw-internal:dagstream_production_feast09_s2id13_30min_demand",
 			expectedErr: "map URN: unexpected BigQuery table FQN 'bq-raw-internal:dagstream_production_feast09_s2id13_30min_demand', expected in format",
 		},
+		{
+			name:        "Invalid",
+			fqn:         ":.",
+			expectedErr: "map URN: unexpected BigQuery table FQN ':.', expected in format",
+		},
 	}
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {