vendor new thingmagic API #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change vendors the mercuryapi into this repository in order to successfully build the python package. The new upstream no longer has a direct link to the API. In updating the new package, this change also fixes several breakages related to the API version bump.
Author
|
I ventured the entire API package. If it would be desirable, I can also reduce the size of this by dropping the java and cs APIs since we exclude them anyway. When I reviewed the license associated with the thingmagic API, it does seem like it permits redistribution so I thought it would be safe to vendor it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change vendors the mercuryapi into this repository in order to successfully build the python package. The new upstream no longer has a direct link to the API.
In updating the new package, this change also fixes several breakages related to the API version bump.