AUT-4506: Add target action to ACCOUNT_MANAGEMENT_AUTHENTICATE audit event #7262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alhcomer
force-pushed
the
AUT-4506
branch
5 times, most recently
from
300711b to
5282a4f
Compare
...unt-management-api/src/main/java/uk/gov/di/accountmanagement/lambda/AuthenticateHandler.java
Outdated
Show resolved
Hide resolved
...unt-management-api/src/main/java/uk/gov/di/accountmanagement/lambda/AuthenticateHandler.java
Outdated
Show resolved
Hide resolved
dbes-gds
reviewed
Oct 10, 2025
| enum: | ||
| - UPDATE_EMAIL | ||
| - UPDATE_PASSWORD | ||
| - DELETE_ACCOUNT |
There was a problem hiding this comment.
Decided to remove UPDATE_MFA as there was some pushback from data concerning the type of update. We can add it later when we've refined the desired schema more
alhcomer
force-pushed
the
AUT-4506
branch
2 times, most recently
from
9ac7b52 to
5e63133
Compare
- Optional targetAction field added. To be used in the AUTH_ACCOUNT_MANAGEMENT_AUTHENTICATE audit event for a target_action extension. - Added missing request body information for /authenticate spec - Bumped openapi spec minor version
- Data requested this extension so that they can identify drop out rate between authenticating and performing the intended action. - The field is optional to maintain backwards compatability.
The high entropy value was being flagged by checkov in GHA
|
Add missing 400, 401, and 403 response examples to /authenticate endpoint to support comprehensive mock server testing scenarios.
Add missing 400, 401, and 403 response examples to /authenticate endpoint to support mock server testing scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a 'target_action' pair to the AUTH_ACCOUNT_MANAGEMENT_AUTHENTICATE audit event. This was requested by data so that they can measure drop off rate for users authenticating and then performing account management actions.
Also adds an 'action_source' extension in anticipation of account components work.
How to review
Checklist