ATO-2024 Multi-session recovery #7264
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe-Edwards-GDS
commented
Oct 7, 2025
| if (orchSession | ||
| .getClientSessions() | ||
| .contains(mismatchedEntity.get().getClientSessionId())) { | ||
| LOG.info("Recovering client session from state"); |
There was a problem hiding this comment.
This might be where we need to update the gs cookie and possibly other state to make the SPOT spinner work.
There was a problem hiding this comment.
Yeah, we'll need to work out how the auth frontend deals with this as well on the spinner page
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wider context of change
https://govukverify.atlassian.net/browse/ATO-2024
The V2 App introduces a new scenario where the app login session clashes with the original client session. In some cases (where the browser is the same) we may still be able to recover.
What’s changed
If
Then we continue processing and redirect to the RP using that client session.
N.B. this probably doesn't work as-is due to the need to go via the SPOT spinner which consumes the gs cookie.
Manual testing
TBD
Checklist
Related PRs
#6889