Skip to content

Conversation

andrew-moores
Copy link
Contributor

@andrew-moores andrew-moores commented Oct 17, 2025

What

Refactor SqsQueueExtension to handle container recreation:

  • Always create fresh queue to handle container restarts
  • Improve queue creation logic with fallback handling
  • Add error handling for queue purge operations
  • Remove unused Optional import

How to review

  1. Code Review
  2. Make an integration test fail then check the next build does not require deleting or recreating docker containers.

Checklist

  • Deployment of this PR will not break active user journeys
  • Impact on orch and auth mutual dependencies has been checked.
  • No changes required or changes have been made to stub-orchestration.
  • A UCD review has been performed.

Related PRs

@andrew-moores andrew-moores requested review from a team as code owners October 17, 2025 14:30
@andrew-moores andrew-moores force-pushed the BAU/make-int-tests-run-after-failure branch from d922c35 to 5bbe4c0 Compare October 17, 2025 14:52
}
}

private String createQueue(String queueName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicky suggestion - could this be renamed to createQueueOrGetExisting or something to that effect?

Refactor SqsQueueExtension to handle container recreation:
- Always create fresh queue to handle container restarts
- Improve queue creation logic with fallback handling
- Add error handling for queue purge operations
- Remove unused Optional import
@andrew-moores andrew-moores force-pushed the BAU/make-int-tests-run-after-failure branch from 5bbe4c0 to d4405d4 Compare October 20, 2025 08:02
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants