initial updates for Grails 7 #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
approved these changes
Nov 19, 2024
| testCompile "org.grails:grails-gorm-testing-support" | ||
| testCompile "org.mockito:mockito-core" | ||
| testCompile "org.grails:grails-web-testing-support" | ||
| testCompile "org.grails.plugins:geb" |
There was a problem hiding this comment.
Was Geb not used? I don't see the testFixatures line to use the container version
There was a problem hiding this comment.
Geb and Selenium are not currently used in any of the tests. Do you want to remove these dependencies for now?
| id "org.asciidoctor.jvm.convert" version "$asciidoctorJvmVersion" | ||
| id "org.asciidoctor.jvm.pdf" version "$asciidoctorJvmVersion" | ||
| id "org.asciidoctor.jvm.epub" version "$asciidoctorJvmVersion" | ||
| id "com.jfrog.artifactory" version "$artifactoryVersion" |
There was a problem hiding this comment.
Why use this plugin still when maven publish / grails publish is capable of publishing?
There was a problem hiding this comment.
this just updates the version, let's tackle publishing in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a very quick pass to get the plugin to build only.