Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a strategy of targeting a grails version by branch version #2

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

jdaugherty
Copy link

@jdaugherty jdaugherty commented Oct 15, 2024

@sbglasius I'm doing cleanup on the repo to start. This change:

  1. Removes the older grails versions from the 6.0.x branch - the idea is we would create branches for the older versions if we need to do a prior release. Moves the grails6/* files to the root.
  2. Update references to vsachinv & sheehan to be this repo instead.
  3. Fixes the publish action so that it invokes the right gradle task.
  4. Adds Sachin Verma to the README.md since they were added to ConsoleGrailsPlugin.groovy
  5. Adds .sdkmanrc to define the java version used by default in development.

I was going to suggest after merging this that we enable publishing to the grails repo like the other projects. Then we can update to grails 7.

@codeconsole
Copy link
Contributor

ConsoleGrailsPlugin -> WebConsoleGrailsPlugin

@codeconsole codeconsole self-requested a review October 15, 2024 04:32
Copy link
Contributor

@codeconsole codeconsole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin should now resolve to grails-web-console because it causes confusion with the console plugin

@codeconsole
Copy link
Contributor

We also need a build and snapshot publish actions. Use this , but update to Liberica. Update it to run all the tests.

@codeconsole
Copy link
Contributor

Change the version from version=6.0-M2 to version=6.0.0-SNAPSHOT

@codeconsole
Copy link
Contributor

Can you update the wrapper to 8.10.2?

@jdaugherty
Copy link
Author

Can you update the wrapper to 8.10.2?

I was going to wait until 7.0.x for the Grails 7 compatibility. So far this is just getting a release for Grails 6.

@jdaugherty
Copy link
Author

jdaugherty commented Oct 15, 2024

Everything but the gradle upgrade is done. I'd say we merge this so we can start work on the 7.0.x build. We also need to make the 6.0.x branch the default for now.

@codeconsole codeconsole merged commit 13b49bd into gpc:6.0.x Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants