Add ESLint + Ruff linting with CI enforcement

.github/workflows/ci.yml

@@ -34,6 +34,12 @@ jobs:
       - name: Install frontend dependencies
         run: cd frontend && npm ci
 
+      - name: Lint Python
+        run: ruff check kernelboard/ tests/
+
+      - name: Lint frontend
+        run: cd frontend && npm run lint
+
       - name: Run Python tests
         run: pytest --tb=short
         continue-on-error: true

CLAUDE.md

@@ -28,6 +28,42 @@ Look for the `hackathons` array around line 87. To add a hackathon:
 Upcoming lectures are pulled live from Discord's scheduled events API (5-minute cache).
 Requires `DISCORD_BOT_TOKEN` and `DISCORD_GUILD_ID` environment variables.
 
+## Database Access
+
+The production PostgreSQL database is hosted on Heroku under the `discord-cluster-manager` app:
+- **Heroku Dashboard:** https://dashboard.heroku.com/apps/discord-cluster-manager
+- **Connection:** Use `heroku pg:psql -a discord-cluster-manager` to connect interactively
+- **Credentials:** Use `heroku pg:credentials:url -a discord-cluster-manager` to get the connection string
+- **Schema:** All tables live under the `leaderboard` schema (e.g., `leaderboard.runs`, `leaderboard.submission`, `leaderboard.leaderboard`, `leaderboard.user_info`, `leaderboard.code_files`, `leaderboard.gpu_type`, `leaderboard.submission_job_status`)
+
+### Key Tables
+- `leaderboard.leaderboard` - Competition definitions (name, deadline, task JSONB)
+- `leaderboard.submission` - User submissions linked to code files
+- `leaderboard.runs` - Individual run results with scores (lower is better), GPU type, pass/fail
+- `leaderboard.user_info` - User accounts (Discord/Google/GitHub OAuth)
+- `leaderboard.gpu_type` - GPU types supported per leaderboard
+- `leaderboard.code_files` - Submitted code with SHA256 hash
+- `leaderboard.submission_job_status` - Job tracking (pending/running/succeeded/failed/timed_out)
+
+### Ranking Logic
+Rankings are computed via SQL window functions:
+1. Best run per user per GPU type (lowest score wins, must be `passed=true`, `secret=false`, `score IS NOT NULL`)
+2. Global rank via `RANK() OVER (PARTITION BY leaderboard_id, runner ORDER BY score ASC)`
+3. GPU priority order: B200 > H100 > MI300 > A100 > L4 > T4
+
+## Linting
+
+CI enforces linting for both Python and the frontend. PRs will fail if either linter reports errors.
+
+**Python (Ruff):**
+- Check: `ruff check kernelboard/ tests/`
+- Auto-fix: `ruff check --fix kernelboard/ tests/`
+- Config: `pyproject.toml` under `[tool.ruff]`
+
+**Frontend (ESLint):**
+- Check: `cd frontend && npm run lint`
+- Auto-fix: `cd frontend && npm run lint -- --fix`
+
 ## Project Structure
 
 - `kernelboard/` - Flask backend

frontend/eslint.config.js

@@ -23,6 +23,12 @@ export default tseslint.config(
         'warn',
         { allowConstantExport: true },
       ],
+      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-unused-vars': ['error', {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_',
+      }],
       'eol-last': ['error', 'always']
     },
   },

frontend/src/App.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it } from "vitest";
-import { render, screen } from "@testing-library/react";
+import { screen } from "@testing-library/react";
 import { MemoryRouter } from "react-router-dom";
 import App from "./App";
 

frontend/src/components/app-layout/NavUserProfile.tsx

@@ -1,6 +1,5 @@
 import { useState } from "react";
 import {
-  Alert,
   Avatar,
   Button,
   Divider,

frontend/src/components/common/EllipsisWithTooltip.tsx

@@ -1,8 +1,6 @@
 import {
   Tooltip,
   Typography,
-  type SxProps,
-  type Theme,
   type TypographyVariant,
 } from "@mui/material";
 import React, { useEffect, useRef, useState } from "react";

frontend/src/components/markdown-renderer/MarkdownRenderer.tsx

@@ -54,7 +54,7 @@ const MarkdownRenderer: React.FC<MarkdownRendererProps> = ({
       remarkPlugins={[remarkGfm, remarkMath]}
       rehypePlugins={[rehypeRaw, rehypeKatex]}
       components={{
-        a: ({ node, ...props }) => (
+        a: ({ node: _node, ...props }) => (
           <a
             style={{
               color: theme.palette.primary.main,
@@ -63,10 +63,10 @@ const MarkdownRenderer: React.FC<MarkdownRendererProps> = ({
             {...props}
           />
         ),
-        figure: ({ node, ...props }) => (
+        figure: ({ node: _node, ...props }) => (
           <figure style={{ textAlign: align, margin: "1.5rem 0" }} {...props} />
         ),
-        figcaption: ({ node, ...props }) => (
+        figcaption: ({ node: _node, ...props }) => (
           <figcaption
             style={{
               fontStyle: "italic",
@@ -76,7 +76,7 @@ const MarkdownRenderer: React.FC<MarkdownRendererProps> = ({
             {...props}
           />
         ),
-        img: ({ node, ...props }) => {
+        img: ({ node: _node, ...props }) => {
           return (
             <div style={{ textAlign: align, margin: "0" }}>
               <img style={styleProps} {...props} alt={props.alt} />

frontend/src/lib/hooks/useApi.ts

@@ -53,13 +53,13 @@ export function fetcherApiCallback<T, Args extends any[]>(
   fetcher: Fetcher<T, Args>,
   redirectMap: Record<number, string> = defaultRedirectMap,
 ) {
-  const navigate = useNavigate();
-  const [data, setData] = useState<T | null>(null);
-  const [error, setError] = useState<string | null>(null);
-  const [errorStatus, setErrorStatus] = useState<number | null>(null);
-  const [loading, setLoading] = useState(true);
+  const navigate = useNavigate(); // eslint-disable-line react-hooks/rules-of-hooks
+  const [data, setData] = useState<T | null>(null); // eslint-disable-line react-hooks/rules-of-hooks
+  const [error, setError] = useState<string | null>(null); // eslint-disable-line react-hooks/rules-of-hooks
+  const [errorStatus, setErrorStatus] = useState<number | null>(null); // eslint-disable-line react-hooks/rules-of-hooks
+  const [loading, setLoading] = useState(true); // eslint-disable-line react-hooks/rules-of-hooks
 
-  const call = useCallback(
+  const call = useCallback( // eslint-disable-line react-hooks/rules-of-hooks
     async (...params: Args) => {
       setLoading(true);
 
@@ -72,8 +72,8 @@ export function fetcherApiCallback<T, Args extends any[]>(
         setData(result);
         return result;
       } catch (e: any) {
-        let status = e.status ? e.status : 0;
-        let msg = e.message ? e.message : "";
+        const status = e.status ? e.status : 0;
+        const msg = e.message ? e.message : "";
 
         // set and logging the error if any
         setError(status);

frontend/src/lib/store/authStore.ts

@@ -27,14 +27,14 @@ export const useAuthStore = create<AuthState>((set, get) => ({
     );
     try {
       const res = await getMe();
-      set((s) => ({
+      set((_s) => ({
         me: res,
         loading: false,
         inFlight: false,
         error: null,
       }));
     } catch (e: any) {
-      set((s) => ({
+      set((_s) => ({
         error: e?.message ?? "Failed to fetch user",
         loading: false,
         inFlight: false,

frontend/src/pages/home/Home.test.tsx

@@ -1,4 +1,4 @@
-import { render, screen, fireEvent, within } from "@testing-library/react";
+import { render, screen } from "@testing-library/react";
 import { BrowserRouter } from "react-router-dom";
 import { ThemeProvider } from "@mui/material";
 import { appTheme } from "../../components/common/styles/theme";
@@ -52,7 +52,7 @@
 
     renderWithProviders(<Home />);
 
     expect(screen.getByText(/Summoning/i)).toBeInTheDocument();
   });
 
   it("shows error message", () => {
@@ -450,7 +450,7 @@
 
       renderWithProviders(<Home />);
 
       const link = screen.getByRole("link");
       expect(link).toHaveAttribute("href", "/leaderboard/42");
     });
 

frontend/src/pages/leaderboard/Leaderboard.test.tsx

@@ -1,4 +1,4 @@
-import { render, screen, fireEvent, within } from "@testing-library/react";
+import { screen, fireEvent, within } from "@testing-library/react";
 import { vi, expect, it, describe, beforeEach } from "vitest";
 import Leaderboard from "./Leaderboard";
 import * as apiHook from "../../lib/hooks/useApi";

frontend/src/pages/leaderboard/Leaderboard.tsx

@@ -269,7 +269,7 @@ export default function Leaderboard() {
                 >
                   <CardTitle fontWeight="bold">Submission</CardTitle>
                   <LeaderboardSubmit
-                    leaderboardId={id!!}
+                    leaderboardId={id!}
                     leaderboardName={data.name}
                     gpuTypes={data.gpu_types}
                     disabled={isExpired(data.deadline)}
@@ -295,9 +295,9 @@ export default function Leaderboard() {
                 )}
                 {/* History List */}
                 <SubmissionHistorySection
-                  leaderboardId={id!!}
+                  leaderboardId={id!}
                   leaderboardName={data.name}
-                  userId={userId!!}
+                  userId={userId!}
                   refreshFlag={refreshFlag}
                 />
               </CardContent>
@@ -313,13 +313,13 @@ export default function Leaderboard() {
                 <CardTitle fontWeight="bold">
                   AI Model Performance Trend
                 </CardTitle>
-                <AiTrendChart leaderboardId={id!!} rankings={data.rankings} />
+                <AiTrendChart leaderboardId={id!} rankings={data.rankings} />
               </CardContent>
             </Card>
             <Card sx={{ mt: 2 }}>
               <CardContent>
                 <CardTitle fontWeight="bold">User Performance Trend</CardTitle>
-                <UserTrendChart leaderboardId={id!!} defaultUser={defaultUser} defaultGpuType={defaultGpuType} />
+                <UserTrendChart leaderboardId={id!} defaultUser={defaultUser} defaultGpuType={defaultGpuType} />
               </CardContent>
             </Card>
           </TabPanel>

frontend/src/pages/leaderboard/components/RankingLists.tsx

@@ -85,15 +85,15 @@ export default function RankingsList({
   const me = useAuthStore((s) => s.me);
   const isAdmin = !!me?.user?.is_admin;
   const [expanded, setExpanded] = useState<Record<string, boolean>>({});
-  const [colorHash, _] = useState<string>(
+  const [colorHash] = useState<string>(
     Math.random().toString(36).slice(2, 8),
   );
   const [codes, setCodes] = useState<Map<number, string>>(new Map());
 
   const submissionIds = useMemo(() => {
     if (!rankings) return [];
     const ids: number[] = [];
-    Object.entries(rankings).forEach(([key, value]) => {
+    Object.entries(rankings).forEach(([_key, value]) => {
       const li = value as any[];
       if (Array.isArray(li) && li.length > 0) {
         li.forEach((item) => {

frontend/src/pages/leaderboard/components/submission-history/SubmissionHistorySection.tsx

@@ -90,7 +90,7 @@ const styles = {
 
 export default function SubmissionHistorySection({
   leaderboardId,
-  leaderboardName,
+  leaderboardName: _leaderboardName,
   userId,
   pageSize = 10,
   refreshFlag,
@@ -128,10 +128,10 @@ export default function SubmissionHistorySection({
     setLastRefresh(new Date());
   }, [leaderboardId, userId, page, pageSize, call]);
 
-  let totalPages =
+  const totalPages =
     data?.limit && data?.total ? Math.ceil(data?.total / data?.limit) : 1;
-  let items: Submission[] = data?.items ?? [];
-  let total: number = data?.total ?? 0;
+  const items: Submission[] = data?.items ?? [];
+  const total: number = data?.total ?? 0;
 
   const tooOld = lastRefresh && now - lastRefresh.getTime() > 10 * 60 * 1000;
 

frontend/src/pages/news/News.test.tsx

@@ -8,6 +8,7 @@
 import { vi, describe, it, expect, beforeEach } from "vitest";
 import News from "./News"; // 假设你当前文件路径为 pages/News.tsx
 import * as apiHook from "../../lib/hooks/useApi";
+import { useParams, useNavigate } from "react-router-dom";
 
 // 统一 mock useApi hook
 vi.mock("../../lib/hooks/useApi", () => ({
@@ -52,7 +53,6 @@
 describe("News", () => {
   beforeEach(() => {
     vi.clearAllMocks();
-    const { useParams, useNavigate } = require("react-router-dom");
     (useParams as ReturnType<typeof vi.fn>).mockReturnValue({});
     (useNavigate as ReturnType<typeof vi.fn>).mockReturnValue(mockNavigate);
   });
@@ -75,7 +75,7 @@
     render(<News />);
 
     // asserts
     expect(screen.getByText(/Summoning/i)).toBeInTheDocument();
   });
 
   it("shows error message", () => {
@@ -119,7 +119,7 @@
     // asserts
     expect(screen.getByText("News and Announcements")).toBeInTheDocument();
 
     const sidebar = screen.getByTestId("news-sidbar");
     const newsContent = screen.getByTestId("news-content");
 
     expect(within(sidebar).getByText("Title One")).toBeInTheDocument();
@@ -154,7 +154,7 @@
     render(<News />);
 
     // asserts
     const sidebar = screen.getByTestId("news-sidbar");
     const newsContent = screen.getByTestId("news-content");
 
     const section = within(newsContent).getByText("Title Two").closest("div");
@@ -181,7 +181,6 @@
   it("scrolls to section when slug is provided in URL", async () => {
     // prepare
     const scrollIntoViewMock = vi.fn();
-    const { useParams } = require("react-router-dom");
     (useParams as ReturnType<typeof vi.fn>).mockReturnValue({ slug: "news-2" });
 
     const mockHookReturn = {
@@ -199,7 +198,7 @@
     // render
     render(<News />);
 
     const newsContent = screen.getByTestId("news-content");
     const section = within(newsContent).getByText("Title Two").closest("div");
     if (section) {
       Object.defineProperty(section, "scrollIntoView", {

kernelboard/__init__.py

@@ -1,22 +1,26 @@
 import http
 import os
-from re import L
+
 from dotenv import load_dotenv
-from flask import Flask, jsonify, redirect, session, g
-from flask_login import LoginManager, current_user
+from flask import Flask, make_response, redirect, send_from_directory
+from flask_login import LoginManager
 from flask_session import Session
 from flask_talisman import Talisman
-from kernelboard.api.auth import User, providers
-from kernelboard.lib import db, env, time, score
-from kernelboard import color, error, health, index, leaderboard, news
+
+from kernelboard import color, health
+from kernelboard import error as error
+from kernelboard import index as index
+from kernelboard import leaderboard as leaderboard
+from kernelboard import news as news
 from kernelboard.api import create_api_blueprint
-from kernelboard.lib.redis_connection import create_redis_connection
-from flask import send_from_directory, make_response
+from kernelboard.api.auth import User, providers
+from kernelboard.lib import db, env, score, time
 from kernelboard.lib.logging import configure_logging
-from kernelboard.og_tags import is_social_crawler, get_og_tags_for_path, inject_og_tags
-from flask_limiter import Limiter
 from kernelboard.lib.rate_limiter import limiter
+from kernelboard.lib.redis_connection import create_redis_connection
 from kernelboard.lib.status_code import http_error
+from kernelboard.og_tags import get_og_tags_for_path, inject_og_tags, is_social_crawler
+
 
 def create_app(test_config=None):
     # Check if we're in development mode:
@@ -123,7 +127,7 @@ def redirect_v2(path=""):
         return redirect(f"/{path}", code=301)
 
     @app.errorhandler(401)
-    def unauthorized(_error):
+    def handle_401(_error):
         return redirect("/401")
 
     @app.errorhandler(404)

kernelboard/api/__init__.py

@@ -1,15 +1,13 @@
-from requests import auth
 from flask import Blueprint
 from werkzeug.exceptions import HTTPException
-from kernelboard.api.submission import submission
-from kernelboard.lib.status_code import http_error, http_success
+
+from kernelboard.api.auth import auth_bp
+from kernelboard.api.events import events_bp
 from kernelboard.api.leaderboard import leaderboard_bp
 from kernelboard.api.leaderboard_summaries import leaderboard_summaries_bp
 from kernelboard.api.news import news_bp
-from kernelboard.api.auth import auth_bp
 from kernelboard.api.submission import submission_bp
-from kernelboard.api.events import events_bp
-
+from kernelboard.lib.status_code import http_error, http_success
 
 
 def create_api_blueprint():

kernelboard/api/auth.py

@@ -7,15 +7,17 @@
 import requests
 from flask import (
     Blueprint,
-    current_app as app,
     redirect,
     request,
     session,
     url_for,
 )
+from flask import (
+    current_app as app,
+)
 from flask_login import UserMixin, current_user, login_user, logout_user
-from kernelboard.lib.auth_utils import ensure_user_info_with_token, get_user_info_from_session
 
+from kernelboard.lib.auth_utils import ensure_user_info_with_token, get_user_info_from_session
 from kernelboard.lib.status_code import http_success
 
 auth_bp = Blueprint("auth", __name__)

kernelboard/api/events.py

@@ -1,11 +1,12 @@
-from http import HTTPStatus
+import logging
 import os
 import time
+from http import HTTPStatus
+
 import requests
 from flask import Blueprint
-from kernelboard.lib.status_code import http_error, http_success
-import logging
 
+from kernelboard.lib.status_code import http_error, http_success
 
 logger = logging.getLogger(__name__)