Conversation
yangw-dev
commented
Aug 26, 2025
kernelboard/api/submission.py
Outdated
| return items, total | ||
|
|
||
|
|
||
| def is_rate_limited(user_id: int, window: dt.timedelta = WINDOW) -> bool: |
Collaborator
Author
There was a problem hiding this comment.
@b9r5
I set rate limite 10 submission per person in 30 mins, let me know if this is reasonable
b9r5
reviewed
Aug 27, 2025
| login_user(User(f"{provider}:{identity}")) | ||
|
|
||
| # 6) Clean up and redirect | ||
| # 6) Clean up and redirec |
Collaborator
There was a problem hiding this comment.
Suggested change
| # 6) Clean up and redirec | |
| # 6) Clean up and redirect |
b9r5
reviewed
Aug 27, 2025
b9r5
reviewed
Aug 27, 2025
b9r5
reviewed
Aug 27, 2025
b9r5
reviewed
Aug 27, 2025
b9r5
reviewed
Aug 27, 2025
Collaborator
b9r5
left a comment
b9r5
left a comment
There was a problem hiding this comment.
Some fairly minor comments, but basically looks good!
Co-authored-by: Ben Horowitz <bhorowit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce submission to gpumode
Call submission api
it calls
post submission apifrom cluster-management pr. The api return sub_id immediately, and update the job status in the background.Details
Demo
Login user
User logged in can see the submission and submission history
Submission
when submit success, user is notified immediately, and user can refresh the submission history to see the status of the submission:
When no login info
User cannot see submission infos when they are not logged in
Handle Submission Failure
Rate limit
Render error when user hit rate limit:
