Conversation
This reverts commit 015607b.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous fix that modified the payload format in GitHub Actions workflows and test configuration. The revert undoes changes that had implemented payload compression and encoding for workflow execution.
- Reverts the mode from "test" back to "script" in the test payload configuration
- Removes payload compression and base64 encoding from both NVIDIA and AMD workflows
- Simplifies payload handling by writing raw JSON directly to file instead of compressed format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/github_test_payload.json | Changes mode field from "test" back to "script" |
| .github/workflows/nvidia_workflow.yml | Removes payload compression/encoding, writes raw JSON to file |
| .github/workflows/amd_workflow.yml | Removes payload compression/encoding, writes raw JSON to file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| "main": "main.py", | ||
| "mode": "test" | ||
| "mode": "script" |
There was a problem hiding this comment.
Reverting the mode from 'test' to 'script' may affect how this payload is processed downstream. Ensure that all consumers of this payload file are compatible with the 'script' mode and that any test-specific logic is properly handled.
| "mode": "script" | |
| "mode": "test" |
| # Now write to file (won't be logged since it's masked) | ||
| echo "$PAYLOAD" > payload.json |
There was a problem hiding this comment.
Removing the compression and base64 encoding may break compatibility with Python scripts that expect the compressed format. Verify that the consuming Python scripts can handle raw JSON payloads or update them accordingly.
| # Now write to file (won't be logged since it's masked) | ||
| echo "$PAYLOAD" > payload.json |
There was a problem hiding this comment.
Removing the compression and base64 encoding may break compatibility with Python scripts that expect the compressed format. Verify that the consuming Python scripts can handle raw JSON payloads or update them accordingly.
| # Now write to file (won't be logged since it's masked) | |
| echo "$PAYLOAD" > payload.json | |
| # Compress and base64-encode the payload before writing to file | |
| echo "$PAYLOAD" | gzip | base64 > payload.json |
Coverage report
This PR does not seem to contain any modification to coverable code. |
1 participant
Reverts #331