Skip to content

Comments

Forward fix the web api pr#345

Merged
yangw-dev merged 4 commits intomainfrom
forwardff
Aug 28, 2025
Merged

Forward fix the web api pr#345
yangw-dev merged 4 commits intomainfrom
forwardff

Conversation

@yangw-dev
Copy link
Collaborator

@yangw-dev yangw-dev commented Aug 28, 2025

Description

Forward fix the web api pr dependency issue

  1. for unittest use monkeypatch to gracefully introduce dummy env var
  2. add dummy report for manager.

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/libkernelbot
  background_submission_manager.py 36, 38-40, 42, 45, 47
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

import pytest
from fastapi import HTTPException

from kernelbot.api.main import validate_user_header
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test the function from kernel, right now we cannot do it until fix the env var setting,
can added to next pr

@yangw-dev yangw-dev requested review from S1ro1 and ngc92 August 28, 2025 19:33
@yangw-dev yangw-dev marked this pull request as ready for review August 28, 2025 19:33
@yangw-dev yangw-dev merged commit c787cfa into main Aug 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants