Skip to content

Comments

remove the non-exist field updated_at#347

Merged
msaroufim merged 4 commits intomainfrom
removeupdate
Aug 30, 2025
Merged

remove the non-exist field updated_at#347
msaroufim merged 4 commits intomainfrom
removeupdate

Conversation

@yangw-dev
Copy link
Collaborator

@yangw-dev yangw-dev commented Aug 28, 2025

Description

Remove non-exist field in the hearbeat update logic

even this has error, it does not affect the functionality of submission now, but may make us lose track of hearbeat of the job,

It's being used here, but exception is silence since it only used for hearbeat tracking
https://github.com/gpu-mode/discord-cluster-manager/blob/a992037eeb8763ce7b1f4d69ea06e41cf93b39c3/src/libkernelbot/background_submission_manager.py#L221

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/libkernelbot
  leaderboard_db.py 378-387
Project Total  

This report was generated by python-coverage-comment-action

@yangw-dev yangw-dev requested review from msaroufim and ngc92 August 28, 2025 22:34
@yangw-dev yangw-dev marked this pull request as ready for review August 28, 2025 22:42
@msaroufim msaroufim merged commit ae407b8 into main Aug 30, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants