Skip to content

Comments

fix#361

Merged
msaroufim merged 1 commit intomainfrom
msaroufim/role
Sep 26, 2025
Merged

fix#361
msaroufim merged 1 commit intomainfrom
msaroufim/role

Conversation

@msaroufim
Copy link
Member

Description

Please provide a brief summary of the changes in this pull request.

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

Copilot AI review requested due to automatic review settings September 26, 2025 16:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes minor fixes to the admin cog functionality, including a code style improvement and adding proper permission validation.

  • Fixed string quote style consistency in datetime formatting
  • Added admin permission check to the get_submission_by_id command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@S1ro1 S1ro1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we for sure should have it by default.

@msaroufim msaroufim merged commit a6b861f into main Sep 26, 2025
6 checks passed
@msaroufim msaroufim deleted the msaroufim/role branch September 26, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants