Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two main issues: fixing the deadline comparison logic to use full datetime objects instead of just dates, and adding validation to detect and handle submissions containing the word "stream" to prevent improper CUDA stream usage.
- Fixed deadline comparison to use full datetime instead of date-only comparison for more accurate deadline validation
- Added stream detection across all submission entry points (Discord bot, API) with warning messages
- Enhanced report generation to support optional extra text parameter for displaying warnings
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libkernelbot/submission.py | Fixed deadline comparison to use full datetime objects instead of date-only comparison |
| src/libkernelbot/report.py | Added optional extra_text parameter to generate_report for prepending messages, plus minor formatting improvements |
| src/libkernelbot/backend.py | Added stream detection warning message and formatting improvements for function signature |
| src/kernelbot/cogs/leaderboard_cog.py | Added stream validation that rejects Discord submissions containing "stream" keyword |
| src/kernelbot/api/api_utils.py | Added stream validation that rejects API submissions containing "stream" keyword |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.