Skip to content

Comments

fix timezone failures#389

Merged
msaroufim merged 2 commits intomainfrom
timezonebug
Jan 7, 2026
Merged

fix timezone failures#389
msaroufim merged 2 commits intomainfrom
timezonebug

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Jan 7, 2026

followup work from fbed4bb since tests weren't updated

AMD timeout feels like a flake

Copilot AI review requested due to automatic review settings January 7, 2026 06:42
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes timezone-related test failures by making datetime objects timezone-aware in test mock data. The changes align the test fixtures with the actual implementation in submission.py, which uses UTC timezone-aware datetime for deadline comparisons.

Key Changes

  • Updated mock deadline values to use datetime.datetime.now(datetime.timezone.utc) instead of naive datetime.datetime.now()
  • Applied consistently across all three occurrences in the test file (mock fixture and two test cases)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@msaroufim msaroufim merged commit 33179ac into main Jan 7, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant