Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow trigger #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix workflow trigger #682

wants to merge 1 commit into from

Conversation

melix
Copy link
Collaborator

@melix melix commented Jan 22, 2025

Fixes #670

@dnestoro I think the issue comes from the fact that we should use the names of the workflows, not their ids, in the list.

@melix melix requested a review from dnestoro January 22, 2025 13:16
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 22, 2025
@dnestoro
Copy link
Collaborator

@melix my question is why we trigger this workflow like this? Why we don't trigger it when something is merged with master? We do the same in the metadata repository, here

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

I think it's done so that we only publish snapshots for successful pipeline. This would be to avoid that a snapshot from a broken master is published. But that's only a guess.

@dnestoro
Copy link
Collaborator

But we are performing checks before anything gets merged into master, right? So if we pass those checks, the master should be in the correct state? Or I am missing some edge case?

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

I don't think this was the case when this workflow was created.

@dnestoro
Copy link
Collaborator

Aha, okay. So should we keep this approach with workflows or we want to switch to the strategy we use in metadata repo? What do you think is the better solution in this case? I am fine with both

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

Both are probably ok, I have no preference either. Let's see if this one works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Pre-release/ snapshot repository unavailable?
2 participants