fix: removereact-reouter-dom on the link element (#1128)

graasp · Dec 12, 2024 · 9d1b1bc · 9d1b1bc
1 parent b915f8f
commit 9d1b1bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/Card/LinkCard.tsx b/src/Card/LinkCard.tsx
@@ -9,8 +9,6 @@ import {
   useTheme,
 } from '@mui/material';
 
-import { Link } from 'react-router-dom';
-
 import { ItemType } from '@graasp/sdk';
 
 import CardThumbnail from './components/CardThumbnail.js';
@@ -50,12 +48,7 @@ const FancyLink = ({
       }}
       data-testid={FANCY_LINK_CARD_TEST_ID}
     >
-      <CardActionArea
-        component={Link}
-        to={url}
-        sx={{ height: '100%' }}
-        onClick={onClick}
-      >
+      <CardActionArea href={url} sx={{ height: '100%' }} onClick={onClick}>
         <Stack direction='row' alignItems='center' height='100%' minWidth={0}>
           <CardThumbnail
             thumbnail={thumbnail}

diff --git a/src/items/LinkItem.tsx b/src/items/LinkItem.tsx
@@ -1,7 +1,6 @@
 import { Alert, Box, Link as MUILink, styled } from '@mui/material';
 
 import { Fragment, memo, useEffect, useState } from 'react';
-import { Link } from 'react-router-dom';
 
 import { LinkItemType, getLinkExtra } from '@graasp/sdk';
 
@@ -234,7 +233,7 @@ const LinkItem = ({
     }
 
     return (
-      <MUILink component={Link} to={url} onClick={onClick}>
+      <MUILink href={url} onClick={onClick}>
         {url}
       </MUILink>
     );