Support column/row deletion in `gr.DataFrame` #10420

abidlabs · 2025-01-23T18:50:07Z

Closes: #631, our oldest open issue! Test with any interactive dataframe demo like demo/matrix_transpose/run.py

gradio-pr-bot · 2025-01-23T18:50:44Z

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
🦄	Changes	detected!	Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/a360c627ea963477993f3bfe972140c07b256796/gradio-5.13.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a360c627ea963477993f3bfe972140c07b256796#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/a360c627ea963477993f3bfe972140c07b256796/gradio-client-1.10.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/a360c627ea963477993f3bfe972140c07b256796/dist/lite.js""></script>

gradio-pr-bot · 2025-01-23T18:52:31Z

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
`@gradio/core`	`patch`
`@gradio/dataframe`	`patch`
`gradio`	`patch`

Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Support column/row deletion in gr.DataFrame

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

abidlabs · 2025-01-24T05:18:45Z

js/dataframe/shared/CellMenuIcons.svelte

@@ -0,0 +1,113 @@
+<script lang="ts">


clearer icons

abidlabs · 2025-01-24T05:19:00Z

demo/matrix_transpose/run.py

@@ -16,6 +16,7 @@ def transpose(matrix):
        [np.random.randint(0, 10, (10, 3)).tolist()],
        [np.random.randint(0, 10, (10, 10)).tolist()],
    ],
+    live=True,


small change that makes this demo easier to use for testing

hannahblair · 2025-01-27T17:37:53Z

~~Both delete buttons seem to be adding rows for me at the moment 🤔~~

hannahblair · 2025-01-28T00:08:22Z

Above comment was me being stupid, looks good! Thanks for handling this. That is a very old issue 😅

The icons are really nice! Much better than before. I'm not too sure about the red hover effect as it's a little bit inconsistent. Also the arrows have something a little bit off with the pixels, see zoomed in screenshots:

When you try to delete a row/col that cant be removed due to the minimum # of row/cols, it simply doesn't delete (as expected) but this might be confusing. I think we should remove the option (or grey it out) when the delete action isn't possible

abidlabs · 2025-01-28T01:35:57Z

Thanks @hannahblair both points make sense, I'll fix!

abidlabs · 2025-01-28T06:55:22Z

Both issues should be fixed now @hannahblair. Let me know if you spot any other issues -- otherwise will merge in tomorrow.

hannahblair

Nice thanks for addressing those! Tested and confirmed that if col_count or row_count is "fixed" then you can't add or remove a row or col.

This is awesome now!! Thanks @abidlabs 🚀🚀

hannahblair · 2025-01-28T15:05:32Z

js/dataframe/shared/Table.svelte

+		parent.focus();
+		if (row_count[1] !== "dynamic") return;
+		if (data.length <= 1) return;
+		console.log("data", data);


oh we should delete these console.logs

support deletion

1a15056

abidlabs marked this pull request as draft January 23, 2025 18:50

abidlabs added the v: patch A change that requires a patch release label Jan 23, 2025

abidlabs and others added 3 commits January 23, 2025 10:51

changes

be98907

changes

23faa1b

add changeset

5c4d7df

abidlabs and others added 6 commits January 23, 2025 20:35

Merge branch 'main' into df-del

e63161a

update icons

9ea67d2

add changeset

4456031

notebook

2436715

Merge branch 'df-del' of github.com:gradio-app/gradio into df-del

6ad0d96

changes

7a02f03

abidlabs commented Jan 24, 2025

View reviewed changes

js/dataframe/shared/CellMenuIcons.svelte

@@ -0,0 +1,113 @@

<script lang="ts">

Copy link

Member Author

abidlabs Jan 24, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer icons

abidlabs commented Jan 24, 2025

View reviewed changes

simplify

36412ec

abidlabs requested review from hannahblair, aliabid94, dawoodkhan82 and pngwn January 24, 2025 05:25

abidlabs marked this pull request as ready for review January 24, 2025 18:55

abidlabs added 4 commits January 27, 2025 22:44

fix icons

1d7df70

changes

d6750fe

changes

cdf49a1

Merge branch 'main' into df-del

12f696a

hannahblair approved these changes Jan 28, 2025

View reviewed changes

hannahblair reviewed Jan 28, 2025

View reviewed changes

abidlabs added 3 commits January 28, 2025 15:41

Merge branch 'main' into df-del

d860c3f

change

074f667

revert

a360c62

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support column/row deletion in `gr.DataFrame` #10420

Support column/row deletion in `gr.DataFrame` #10420

abidlabs commented Jan 23, 2025 •

edited

Loading

gradio-pr-bot commented Jan 23, 2025 •

edited

Loading

gradio-pr-bot commented Jan 23, 2025 •

edited

Loading

Something isn't right?

abidlabs Jan 24, 2025 •

edited

Loading

abidlabs Jan 24, 2025

hannahblair commented Jan 27, 2025 •

edited

Loading

hannahblair commented Jan 28, 2025 •

edited

Loading

abidlabs commented Jan 28, 2025

abidlabs commented Jan 28, 2025

hannahblair left a comment

hannahblair Jan 28, 2025

abidlabs Jan 28, 2025

Support column/row deletion in gr.DataFrame #10420

Are you sure you want to change the base?

Support column/row deletion in gr.DataFrame #10420

Conversation

abidlabs commented Jan 23, 2025 • edited Loading

gradio-pr-bot commented Jan 23, 2025 • edited Loading

🪼 branch checks and previews

gradio-pr-bot commented Jan 23, 2025 • edited Loading

🦄 change detected

This Pull Request includes changes to the following packages.

With the following changelog entry.

Something isn't right?

abidlabs Jan 24, 2025 • edited Loading

Choose a reason for hiding this comment

abidlabs Jan 24, 2025

Choose a reason for hiding this comment

hannahblair commented Jan 27, 2025 • edited Loading

hannahblair commented Jan 28, 2025 • edited Loading

abidlabs commented Jan 28, 2025

abidlabs commented Jan 28, 2025

hannahblair left a comment

Choose a reason for hiding this comment

hannahblair Jan 28, 2025

Choose a reason for hiding this comment

abidlabs Jan 28, 2025

Choose a reason for hiding this comment

Support column/row deletion in `gr.DataFrame` #10420

Support column/row deletion in `gr.DataFrame` #10420

abidlabs commented Jan 23, 2025 •

edited

Loading

gradio-pr-bot commented Jan 23, 2025 •

edited

Loading

gradio-pr-bot commented Jan 23, 2025 •

edited

Loading

abidlabs Jan 24, 2025 •

edited

Loading

hannahblair commented Jan 27, 2025 •

edited

Loading

hannahblair commented Jan 28, 2025 •

edited

Loading