-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rendering javascript in gr.HTML
#10442
Closed
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/9943b383e1e820c5c25b85a2ec84d72013da85c0/gradio-5.13.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9943b383e1e820c5c25b85a2ec84d72013da85c0#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/9943b383e1e820c5c25b85a2ec84d72013da85c0/gradio-client-1.10.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/9943b383e1e820c5c25b85a2ec84d72013da85c0/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
changed the title
Allow rendering javascripti in
Allow rendering javascript in Jan 27, 2025
gr.HTML
gr.HTML
abidlabs
requested review from
aliabid94,
dawoodkhan82,
pngwn,
hannahblair and
freddyaboulton
January 27, 2025 21:11
Upon further reflection, a user can just iframe the value themselves, instead of us doing it. Will close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We frequently get issues from users who want to dump HTML + JS into a gr.HTML component as a bypass (e.g. to display graphs using a custom js library) only to find that the HTML does not display as expected. That's because we strip out the JS and we tell people to instead use the js tags in Blocks to include the relevant js. But this requires manual parsing on the user's part. As discussed internally, it would make gradio more hackable if we could support this pattern
Closes: #10429