-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce versioned source set and optional API source set #88
Open
lacasseio
wants to merge
19
commits into
main
Choose a base branch
from
lacasseio/versioned-and-api-rules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Consumer of this plugin will only get the API classes when an API source set is declared. Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Signed-off-by: Daniel Lacasse <daniel@lacasse.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin authors will now be able to split their API and implementation, effectively hiding any implementation details from consumers of the plugin. This feature is only available if the build specifies an
apiSourceSet
:This PR also introduced versioned source sets, meaning the source sets will be tied to a specific Gradle version. The Gradle API dependency will reflect the selected Gradle version. At the moment, we rely on a naming convention:
The main source set will automatically include an
implementation
dependency on each versioned source set. If an API source set is declared, then each versioned source set will have acompileOnly
dependency on the API source set.