[Renovate Bot] Update AGP versions (patch) #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfeo
added a commit
that referenced
this pull request
Jan 13, 2025
Since #1742, the `generate_versions` CI job [succeeds even though it can't parse the JSON file][1]. Parsing fails because `jq` [doesn't support JSON5][2]. The job succeeds silently despite this failure because it's ran inside [command substitution][3]. This currently results in #1751 not running proper tests. Fix the `generate_versions` CI job to correctly parse the JSON5 file by stripping comment lines before passing its content to `jq`. Also ensure the job will fail if the step fails by running it once outside command substitution and ensuring `pipefail` is on. This replaces the "debug" step. [1]: https://github.com/gradle/android-cache-fix-gradle-plugin/actions/runs/12717112831 [2]: jqlang/jq#1571 [3]: https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html
Signed-off-by: Renovate Bot for Gradle <bot-gh-dv-shared+renovate@gradle.com>
gabrielfeo
force-pushed
the
renovate/patch-agp-versions
branch
from
510ef85 to
cc223c2
Compare
(cherry picked from commit 0d2e07e9cb3a078755e0678cc15df9fd6cce2b94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.7.2->8.7.38.8.0-beta01->8.8.08.9.0-alpha04->8.9.0-alpha09Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.