Update Renovate config to avoid JSON5 #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfeo
force-pushed
the
gf/renovate-no-comments
branch
from
4f9fb1e to
2d455f2
Compare
erichaagdev
reviewed
Jan 14, 2025
cdsap
approved these changes
Jan 14, 2025
erichaagdev
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1742, Renovate was set up with a more usual standard
regexmatcher configuration, which is to search for versions in lines annotated with a comment// renovate: .... However, theversions.jsonfile is parsed by several tools which don't support JSON5 or any form of comments, namely Groovy'sjsonpackage andjq. Groovyjsonrequired using a lenient mode (#1742), which may suppress useful validations, whilejqrequired stripping the comments beforehand (#1752). Moving away from JSON5 would be a simpler solution.Revert the
versions.jsonback from JSON5 to plain JSON and change the Renovate config to match the version properties based on the fact that their values are lists, e.g."8.8.0": [. Matching the version ingradle.propertiesis also simplified to no longer require a comment.Tested with a dry-run of gradle/renovate-agent against this repo and the Renovate GitHub app against a fork, which created an example PR.