-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run help on root project to speed up project probe #528
Conversation
I think that makes sense. There are some tests failing where we check that
Replacing |
794bbac
to
304eaa6
Compare
I'm having trouble running the tests locally with an ARM mac, possibly because this supports such old gradle versions. For now i just globally replaced the expected output but I doubt that is going to pass |
I think it should do the trick. Let's see. And I see StudioPluginIntegrationTest is flaky so ignore that one.. We need to upgrade Gradle version, thanks for a reminder. |
Signed-off-by: Josh Friend <jfriend@squareup.com>
304eaa6
to
c29fb00
Compare
Ok, I might have it this time 😆 |
I also have arm mac, but it works for me. Maybe it's an issue for you, since we request toolchains for JDK8 and maybe you don't have arm version of JDK8? |
I adjusted Thanks for the contribution! |
Yeah that must be why, I checked and I don't have one installed (just switched to a new laptop), I'll get one for next time! Foojay resolver would be a nice addition to do that automatically. Thanks for fixing the remaining issues, hope it wasn't too annoying for you! |
It has fixes to make initial environment probe faster gradle/gradle-profiler#528
Related to #484, running
help
takes a significant amount of time in our build because it is so large and it configures the whole project just to find a few basic pieces of info. Using:help
on the root project makes this considerably faster.