Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beyla integration test #1699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add beyla integration test #1699

wants to merge 1 commit into from

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Sep 18, 2024

I reworked the integration tests to use test containers instead of running Alloy's binary on the host directly for two reasons:

  • some components (such as the Beyla one) require rights that the Github runner's host does not have. This is solved by running Alloy in test containers with privileges.
  • some components only run on specific linux (for example Beyla, Unix, SNMP). Now that Alloy is running in a test container, the tests don't depend on the OS anymore

Additionally I added a test for Beyla

The annoying bit is that building the Alloy docker image takes time and disk space. As a result, I needed to use a bigger github runner for this task

@wildum wildum force-pushed the add-beyla-integration-test branch 2 times, most recently from 72173fa to 38a405d Compare October 11, 2024 12:08
@wildum wildum marked this pull request as ready for review October 11, 2024 12:58
@wildum wildum requested a review from a team as a code owner October 11, 2024 12:58
Copy link
Contributor

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annoying bit is that building the Alloy docker image takes time and disk space. As a result, I needed to use a bigger github runner for this task

Can the integration tests reuse the docker image which the "official" CI step for image generation created?

@@ -812,10 +811,52 @@ require (

)

require github.com/testcontainers/testcontainers-go/modules/compose v0.33.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to put this in the main require block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants