Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parser for azureeventhubs message without time field #1990

Merged

Conversation

andriikushch
Copy link
Contributor

@andriikushch andriikushch commented Oct 29, 2024

PR Description

This PR is fixing the same bug described for the Loki project in:

The Azure Event Hubs messages parser ignores records that don't contain the time field.

  • This change accepts such records if they contain the timeStamp field instead.
  • For the parsed time, the location is set to the UTC

Which issue(s) this PR fixes

Related to:

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@andriikushch andriikushch marked this pull request as ready for review October 29, 2024 10:35
@andriikushch andriikushch requested a review from a team as a code owner October 29, 2024 10:35
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit for the changelog

andriikushch and others added 3 commits October 29, 2024 13:27
Co-authored-by: William Dumont <william.dumont@grafana.com>
@wildum
Copy link
Contributor

wildum commented Oct 30, 2024

Sorry one more thing before merging: at the top of the parser file there is a comment saying that the code is copied from Loki with a ref to the version. I see that now the fix has been merged in loki, could you update the ref of the commit to match the current state in Loki please?

@andriikushch
Copy link
Contributor Author

Sorry one more thing before merging: at the top of the parser file there is a comment saying that the code is copied from Loki with a ref to the version. I see that now the fix has been merged in loki, could you update the ref of the commit to match the current state in Loki please?

Sure 👍

I have updated a link to:

This commit contains the same fix and was recently merged into the Loki project.

@wildum wildum merged commit 1c2ec56 into main Oct 30, 2024
17 of 18 checks passed
@wildum wildum deleted the andrii/fix-event-hub-log-message-parsing-without-time-field branch October 30, 2024 11:29
@wildum
Copy link
Contributor

wildum commented Oct 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants