Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pyroscope.ebpf): detect libc version , handle short buildid properly #768

Merged
merged 3 commits into from
May 7, 2024
Merged

fix(pyroscope.ebpf): detect libc version , handle short buildid properly #768

merged 3 commits into from
May 7, 2024

Conversation

korniltsev
Copy link
Contributor

@korniltsev korniltsev commented May 6, 2024 •
edited
Loading

PR Description

Update pyroscope/ebpf dep from 0.4.6 to 0.4.7 to include fixes for two issues grafana/pyroscope#3268

  1. detect libc version properly when libc file name is libc-2.31.so and not libc.so.6
  2. treat elf files with short build id (8 bytes) properly

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested a review from simonswine May 6, 2024 09:41
@wildum
Copy link
Contributor

wildum commented May 7, 2024

hey, thanks for doing the update :) Could you make an entry in the changelog in a new "### Other changes" part under "Main unreleased" please?
Something like: Upgrading pyroscope/ebpf from 0.4.6 to 0.4.7:

  • detect libc version properly when libc file name is libc-2.31.so and not libc.so.6
  • treat elf files with short build id (8 bytes) properly

@korniltsev korniltsev merged commit f0283e0 into main May 7, 2024
18 checks passed
@korniltsev korniltsev deleted the ebpf-update-dependency branch May 7, 2024 15:17
wildum pushed a commit that referenced this pull request May 8, 2024
@korniltsev @wildum
fix(pyroscope.ebpf): detect libc version , handle short buildid prope…
0ec1734 
…rly (#768)
@wildum wildum mentioned this pull request May 8, 2024
Merged
wildum added a commit that referenced this pull request May 8, 2024
@wildum @korniltsev
Backport pyroscope ebpf upgrade (#805)
001c104 
* fix(pyroscope.ebpf): detect libc version , handle short buildid properly (#768)

* fix changelog

---------

Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com>
@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label May 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wildum wildum wildum approved these changes

@simonswine simonswine Awaiting requested review from simonswine

Assignees
No one assigned
Labels
backport-to-agent PR should be backported to the agent repo. frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korniltsev @wildum @rfratto