Merge pull request #311 from asserts/radha/sc-16162

Add prefix `d_` for dimension labels
grafana · Jul 17, 2023 · 9c36eb1 · 9c36eb1
2 parents a044003 + f3e1920
commit 9c36eb1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/ai/asserts/aws/cloudwatch/metrics/MetricStreamController.java b/src/main/java/ai/asserts/aws/cloudwatch/metrics/MetricStreamController.java
@@ -226,7 +226,7 @@ private void publishMetric(CloudWatchMetric metric) {
         metricMap.put("namespace", metricNamespace);
 
         if (!CollectionUtils.isEmpty(metric.getDimensions())) {
-            metric.getDimensions().forEach((k, v) -> metricMap.put(metricNameUtil.toSnakeCase(k), v));
+            metric.getDimensions().forEach((k, v) -> metricMap.put("d_" + metricNameUtil.toSnakeCase(k), v));
         }
         Optional<CWNamespace> namespaceOpt =
                 Arrays.stream(CWNamespace.values()).filter(f -> f.getNamespace().equals(metricNamespace))

diff --git a/src/test/java/ai/asserts/aws/cloudwatch/metrics/MetricStreamControllerTest.java b/src/test/java/ai/asserts/aws/cloudwatch/metrics/MetricStreamControllerTest.java
@@ -314,7 +314,7 @@ private void expectedCallsWhileProcessingData() {
 
         SortedMap<String, String> metricLabels = new TreeMap<>();
         metricLabels.put("tenant", "acme");
-        metricLabels.put("delivery_stream_name", "PUT-HTP-SliCQ");
+        metricLabels.put("d_delivery_stream_name", "PUT-HTP-SliCQ");
         metricLabels.put("account_id", "123");
         metricLabels.put("namespace", "AWS/Firehose");
         metricLabels.put("region", "r1");