Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Playwright and k6 E2E tests for comparison #637

Merged
merged 15 commits into from
Nov 6, 2023
Merged

Add Playwright and k6 E2E tests for comparison #637

merged 15 commits into from
Nov 6, 2023

Conversation

adamyeats
Copy link
Contributor

No description provided.

@adamyeats adamyeats added datasource/ADX type/chore github_actions Pull requests that update GitHub Actions code labels Oct 2, 2023
@adamyeats adamyeats self-assigned this Oct 2, 2023
@adamyeats adamyeats force-pushed the e2e-comparison branch 2 times, most recently from ebba88d to d517b18 Compare October 2, 2023 15:21
@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:995781ec6978227e5ae7266cf764f3cbe2a87832pre

@adamyeats adamyeats force-pushed the e2e-comparison branch 15 times, most recently from 8e7216b to 354d145 Compare October 9, 2023 14:27
@adamyeats adamyeats force-pushed the e2e-comparison branch 8 times, most recently from ea11c45 to f899d58 Compare October 10, 2023 15:17
aangelisc
aangelisc previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊 great stuff! Are all of the changes in cspell.config.json needed? There are some duplicates in there

@adamyeats
Copy link
Contributor Author

LGTM 😊 great stuff! Are all of the changes in cspell.config.json needed? There are some duplicates in there

Thanks for pointing this out, I've removed the duplicates! I sorted those lines alphabetically which made the duplicates easy to spot, so I would say that the change is worth keeping IMO

aangelisc
aangelisc previously approved these changes Oct 26, 2023
View reviewed changes
alyssabull
alyssabull previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@alyssabull alyssabull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - amazing work! 💪

@vickyyyyyyy vickyyyyyyy linked an issue Nov 3, 2023 that may be closed by this pull request
Add k6 testing #608
Closed
@aangelisc aangelisc dismissed stale reviews from alyssabull and themself via 995781e November 3, 2023 16:03
@adamyeats adamyeats merged commit 095a2fb into main Nov 6, 2023
10 checks passed
@adamyeats adamyeats deleted the e2e-comparison branch November 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@alyssabull alyssabull alyssabull left review comments

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

Assignees

@adamyeats adamyeats

Labels
datasource/ADX github_actions Pull requests that update GitHub Actions code type/chore
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add k6 testing
3 participants
@adamyeats @aangelisc @alyssabull