Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes process metrics when the application has not sent/received any request #1225

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Oct 3, 2024

Addresses #1219 by sending a "Process Alive" signal that would reach the process metrics pipeline even before any other client/server request are instrumented.

Use cases:

  • Provides process metrics during long initialization times
  • Provides process metrics in applications with unsupported protocols (but you can still see them via network metrics)

@mariomac mariomac added the bug Something isn't working label Oct 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (ea991e3) to head (5e5a359).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/discover/attacher.go 43.47% 12 Missing and 1 partial ⚠️
pkg/export/prom/prom.go 0.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (ea991e3) and HEAD (5e5a359). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (ea991e3) HEAD (5e5a359)
k8s-integration-test 1 0
integration-test 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1225       +/-   ##
===========================================
- Coverage   81.72%   67.35%   -14.37%     
===========================================
  Files         137      137               
  Lines       11483    11508       +25     
===========================================
- Hits         9384     7751     -1633     
- Misses       1560     3234     +1674     
+ Partials      539      523       -16     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test 36.15% <64.28%> (+0.06%) ⬆️
unittests 52.88% <4.76%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants