Add tests for recycling services #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
reviewed
Apr 26, 2024
Comment on lines
+136
to
+137
| {Key: "k8s.pod.uid", Type: "string", Value: k8s.UUIDRegex}, | ||
| {Key: "k8s.pod.start_time", Type: "string", Value: k8s.TimeRegex}, |
There was a problem hiding this comment.
Don't know if needed, but maybe you can also verify that the pod UID and start time have changed from the previous pod, to double-check the restart.
There was a problem hiding this comment.
Great idea! I'll add this.
mariomac
approved these changes
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
- Coverage 76.70% 68.94% -7.76%
==========================================
Files 107 104 -3
Lines 9276 9242 -34
==========================================
- Hits 7115 6372 -743
- Misses 1776 2410 +634
- Partials 385 460 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds k8s tests where we prove Beyla works on restart of services.