Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude generated files from code #812

Closed
wants to merge 2 commits into from

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented May 7, 2024

Automate also scripts to generate files before compiling, testing, etc.

@mariomac mariomac added the wip work in progress label May 7, 2024
@grcevski
Copy link
Contributor

grcevski commented May 7, 2024

I think this would be huge if we can do it, but I wonder if this will actually work if someone installs Beyla with go install? Does this break the Alloy integration?

@marctc
Copy link
Contributor

marctc commented May 7, 2024

Does this break the Alloy integration?

Likely, testing

@mariomac
Copy link
Contributor Author

mariomac commented May 7, 2024

Closing PR. We will take the approach of leaving the generated files here and just verify their integrity with docker-generate.

@mariomac mariomac closed this May 7, 2024
@mariomac mariomac deleted the generate-files branch May 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants