[WIP] [experimental] replace ring gogoproto with csproto #535
francoposaAnnotations
10 errors and 4 warnings
|
Check:
ring/ring_extra.go#L9
receiver-naming: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (revive)
|
|
Check:
ring/model.go#L89
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/model.go#L99
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/model.go#L118
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/basic_lifecycler.go#L305
copylocks: call of l.delegate.OnRingInstanceRegister copies lock value: github.com/grafana/dskit/ring.Desc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
ring/basic_lifecycler.go#L465
copylocks: call of ringDesc.SetIngesterVal copies lock value: github.com/grafana/dskit/ring.InstanceDesc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
ring/basic_lifecycler_delegates.go#L24
copylocks: OnRingInstanceRegister passes lock by value: github.com/grafana/dskit/ring.Desc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
ring/basic_lifecycler_delegates.go#L25
copylocks: call of d.next.OnRingInstanceRegister copies lock value: github.com/grafana/dskit/ring.Desc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
ring/basic_lifecycler_delegates.go#L60
copylocks: OnRingInstanceRegister passes lock by value: github.com/grafana/dskit/ring.Desc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
ring/basic_lifecycler_delegates.go#L64
copylocks: call of d.next.OnRingInstanceRegister copies lock value: github.com/grafana/dskit/ring.Desc contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.21.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.22.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.23.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|