[WIP] [experimental] replace ring gogoproto with csproto #536
francoposaAnnotations
10 errors and 4 warnings
|
Check:
ring/ring_extra.go#L9
receiver-naming: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (revive)
|
|
Check:
ring/model.go#L88
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/model.go#L98
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/model.go#L117
receiver-naming: receiver name d should be consistent with previous receiver name x for Desc (revive)
|
|
Check:
ring/partition_ring_model.go#L22
receiver-naming: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (revive)
|
|
Check:
ring/partition_ring_model.go#L63
receiver-naming: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (revive)
|
|
Check:
kv/memberlist/http_status_handler.go#L75
copylocks: range var m copies lock: github.com/grafana/dskit/kv/memberlist.Message contains github.com/grafana/dskit/kv/memberlist.KeyValuePair contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
kv/memberlist/http_status_handler.go#L77
copylocks: call of viewMessage copies lock value: github.com/grafana/dskit/kv/memberlist.Message contains github.com/grafana/dskit/kv/memberlist.KeyValuePair contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
kv/memberlist/http_status_handler.go#L139
copylocks: viewMessage passes lock by value: github.com/grafana/dskit/kv/memberlist.Message contains github.com/grafana/dskit/kv/memberlist.KeyValuePair contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check:
kv/memberlist/memberlist_client.go#L1137
copylocks: literal copies lock value from kvPair: github.com/grafana/dskit/kv/memberlist.KeyValuePair contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.23.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.21.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test on Go 1.22.x
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|