Skip to content

Commit

Permalink
memberlist: Log fast-join failures at info instead of debug (#585)
Browse files Browse the repository at this point in the history
Not being able to fast-join via contacting a node is suspicious and might
indicate a problem. Logging at info makes this easier to troubleshoot.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
  • Loading branch information
56quarters authored Sep 20, 2024
1 parent 9102f24 commit 560bb26
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
* [CHANGE] Cache: Remove superfluous `cache.RemoteCacheClient` interface and unify all caches using the `cache.Cache` interface. #520
* [CHANGE] Updated the minimum required Go version to 1.21. #540
* [CHANGE] memberlist: Metric `memberlist_client_messages_in_broadcast_queue` is now split into `queue="local"` and `queue="gossip"` values. #539
* [CHANGE] memberlist: Failure to fast-join a cluster via contacting a node is now logged at `info` instead of `debug`. #585
* [CHANGE] `Service.AddListener` and `Manager.AddListener` now return function for stopping the listener. #564
* [FEATURE] Cache: Add support for configuring a Redis cache backend. #268 #271 #276
* [FEATURE] Add support for waiting on the rate limiter using the new `WaitN` method. #279
Expand Down
2 changes: 1 addition & 1 deletion kv/memberlist/memberlist_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ func (m *KV) fastJoinMembersOnStartup(ctx context.Context) {
for toJoin > 0 && len(nodes) > 0 && ctx.Err() == nil {
reached, err := m.memberlist.Join(nodes[0:1]) // Try to join single node only.
if err != nil {
level.Debug(m.logger).Log("msg", "fast-joining node failed", "node", nodes[0], "err", err)
level.Info(m.logger).Log("msg", "fast-joining node failed", "node", nodes[0], "err", err)
}

totalJoined += reached
Expand Down

0 comments on commit 560bb26

Please sign in to comment.