Modify WritableInstancesInZoneCount to WritableInstancesWithTokensCount. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
added a commit
to jhalterman/mimir
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
jhalterman
approved these changes
Aug 14, 2024
pstibrany
deleted the
Modify-WritableInstancesInZoneCount-to-WritableInstancesWithTokensCount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
PR #560 added
WritableInstancesInZoneCountandWritableInstancesWithTokensInZoneCountmethods to be used by Mimir limits computation when using new read-only ingester mode.However to compute limits we need
WritableInstancesWithTokensCountwhen zone-awareness is disabled, and don't needWritableInstancesInZoneCount. This PR replacesWritableInstancesInZoneCountwithWritableInstancesWithTokensCount.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]