Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

grafana / dskit Public

Notifications You must be signed in to change notification settings
Fork 69
Star 484

Code
Issues 33
Pull requests 22
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Filter out read-only instances, but skip filtering when it's not required.#565

Merged

pstibrany merged 18 commits intomaingrafana/dskit:mainfrom filter-out-old-read-only-instances-on-readgrafana/dskit:filter-out-old-read-only-instances-on-readCopy head branch name to clipboard

Aug 23, 2024

+687-362

Conversation Commits18 (18)Checks Files changed

Commits

Commits on Aug 15, 2024

Filter out read-only instances, but skip filtering when it's not required.
pstibrany
committed
Update TestRing_ShuffleShardWithLookback_CachingConcurrency test.
pstibrany
committed
Update benchmark.
pstibrany
committed
Make sure to updateRing after switching instance to read only or back, because we need to update new flags that rely on read-only modes.
pstibrany
committed

Commits on Aug 16, 2024

Don't return full ring when lookbackPeriod == 0.
pstibrany
committed
Use all available instances when size <= 0.
pstibrany
committed
Merge branch 'main' into filter-out-old-read-only-instances-on-read
jhalterman
committed
Merge branch 'main' into filter-out-old-read-only-instances-on-read
jhalterman
committed

Commits on Aug 20, 2024

Filter out read-only instances more efficiently for shard size <= 0.
pstibrany
committed
Use pointers for readOnlyInstances and oldestReadOnlyUpdatedTimestamp.
pstibrany
committed
Added test for TestRing_filterOutReadOnlyInstances.
pstibrany
committed
Add tests for filtering read-only instances and shardSize=0.
pstibrany
committed
Update comment.
pstibrany
committed

Commits on Aug 22, 2024

Extract check for including read-only instance in the shuffle shard into a function.
pstibrany
committed
Moved instance-filtering back to shuffleShard, added instance filtering when number of desired instances is >= number of instances in the zone.
pstibrany
committed
Normalize size <= 0 to math.MaxInt for use in cache-key.
pstibrany
committed
Revert change that removed optimization in case when ZoneAwareness was enabled and requested shardSize <= 0.
pstibrany
committed
empty, poke CI
pstibrany
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.