Upgrade to golangci-lint v1.60.1 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/upgrade-golangci-lint
branch
from
6a168e7 to
323b590
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/upgrade-golangci-lint
branch
from
323b590 to
28652f4
Compare
colega
reviewed
Aug 22, 2024
| @@ -316,7 +316,7 @@ func DoUntilQuorumWithoutSuccessfulContextCancellation[T any](ctx context.Contex | |||
| ext.Error.Set(cfg.Logger.Span, true) | |||
| } | |||
|
|
|||
| contextTracker.cancelAllContexts(cancellation.NewErrorf(cause)) | |||
There was a problem hiding this comment.
I can't see why the new version is better.
There was a problem hiding this comment.
It's generally because the linter thinks the non-formatting version should be used, if there's no string formatting. Why do you eventually think the linter is wrong about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrade to golangci-lint v1.60.1, in which
staticcheckforbids callingprintfstyle functions without a formatting string/arguments.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]