Skip to content

more useful body size buckets for response/request message bytes metrics #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 17, 2025

The current body size buckets are not very useful because they start at 1MB, but many of our service's responses are <1MB in size. The buckets are used in the metrics response_message_bytes and request_message_bytes. For example this histogram which shows the sizes of Mimir ingester responses is not very useful because all buckets have the same values: explore

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay marked this pull request as ready for review January 17, 2025 13:32
@replay replay changed the title more useful body size buckets more useful body size buckets for response/request message bytes metrics Jan 17, 2025
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay merged commit 36b56b1 into main Jan 17, 2025
5 checks passed
@replay replay deleted the more-useful-body-size-buckets branch January 17, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants