Adding grpc_cluster client and server middleware #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/grpc-cluster
branch
from
528308b to
4885c0c
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/grpc-cluster
branch
from
4885c0c to
b5ceef9
Compare
aknuds1
reviewed
Jan 28, 2025
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
aknuds1
reviewed
Jan 28, 2025
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
aknuds1
reviewed
Jan 28, 2025
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduces 2 gRPC middlewares:
grpc.UnaryClientInterceptor, that propagates a given cluster info to the outgoing gRPC metadata.grpc.UnaryServerInterceptor, that checks if the incoming gRPC metadata contain any cluster information and if so, checks if the latter corresponds to the given cluster info. If it is the case, the request is further propagated. Otherwise, an error is returned.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]