chore: Use label to upload artifacts #457
Open
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
ifrost
had a problem deploying
to
gcs-no-approval
GitHub Actions
Failure
…ost/label-to-upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Fixes: #443
Important
Before merging to main update restriction rules for gcs-no-approval
📖 Summary of the changes
With this change we can trigger upload of artifacts from PRs by adding "upload" label to a PR. This will trigger a separate step for upload (skipping e2e tests to speed it up).
This way we will get a green "Squash and merge" button even if the Upload was not triggered and reduce number of notifications sent.
🧪 How to test?
Not really possible to test it easily without merging new workflow to the main branch. I tested it in ifrost/deployme#17. By adding additional label "upload" another flow is triggered and added to PR:
Screen.Recording.2025-03-11.at.17.22.47.mov