chore: add missing response time (#465)

grafana · Jan 24, 2024 · 00cb194 · 00cb194
1 parent 7444ea8
commit 00cb194
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Next
 
+- Enhancement (`@grafana/faro-web-sdk`): add response time to performance timings (#465).
+
 ## 1.3.6
 
 - Feature preview (`@grafana/faro-web-sdk`): instrument navigation and resource timings. As long as

diff --git a/packages/web-sdk/src/instrumentations/performance/performanceUtils.test.ts b/packages/web-sdk/src/instrumentations/performance/performanceUtils.test.ts
@@ -26,6 +26,7 @@ describe('performanceUtils', () => {
       tlsNegotiationTime: '33',
       redirectTime: '1',
       requestTime: '109',
+      responseTime: '0',
       fetchTime: '305',
       serviceWorkerTime: '237',
       decodedBodySize: '530675',

diff --git a/packages/web-sdk/src/instrumentations/performance/performanceUtils.ts b/packages/web-sdk/src/instrumentations/performance/performanceUtils.ts
@@ -56,6 +56,7 @@ export function calculateFaroResourceTiming(resourceEntryRaw: PerformanceResourc
     tlsNegotiationTime: toFaroPerformanceTimingString(requestStart - secureConnectionStart),
     redirectTime: toFaroPerformanceTimingString(redirectEnd - redirectStart),
     requestTime: toFaroPerformanceTimingString(responseStart - requestStart),
+    responseTime: toFaroPerformanceTimingString(responseEnd - responseStart),
     fetchTime: toFaroPerformanceTimingString(responseEnd - fetchStart),
     serviceWorkerTime: toFaroPerformanceTimingString(fetchStart - workerStart),
     decodedBodySize: toFaroPerformanceTimingString(decodedBodySize),

diff --git a/packages/web-sdk/src/instrumentations/performance/types.ts b/packages/web-sdk/src/instrumentations/performance/types.ts
@@ -18,6 +18,7 @@ export type FaroResourceTiming = Readonly<{
   redirectTime: string;
   requestTime: string;
   fetchTime: string;
+  responseTime: string;
   serviceWorkerTime: string;
   decodedBodySize: string;
   encodedBodySize: string;
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,8 @@ @@
     ## Next
+    - Enhancement (`@grafana/faro-web-sdk`): add response time to performance timings (#465).
     ## 1.3.6
     - Feature preview (`@grafana/faro-web-sdk`): instrument navigation and resource timings. As long as
@@ Expand Down @@