Enable PDC on Github Datasource #527
Open
+62
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transport is overridden for access token client
|
|
zoltanbedi
requested changes
Nov 10, 2025
src/views/ConfigEditor.tsx
Outdated
| )} | ||
| </ConfigSection> | ||
|
|
||
| {config.featureToggles['secureSocksDSProxyEnabled' as keyof FeatureToggles] && gte(config.buildInfo.version, '10.0.0') && ( |
Member
There was a problem hiding this comment.
Suggested change
| {config.featureToggles['secureSocksDSProxyEnabled' as keyof FeatureToggles] && gte(config.buildInfo.version, '10.0.0') && ( | |
| {config.secureSocksDSProxyEnabled && ( |
Author
There was a problem hiding this comment.
So I tried changing this to only checking config.secureSocksDSProxyEnabled but this does not seem to hide the UI portion for secure socks:
Here is the feature toggle for secureSocksDSProxyEnabled disabled:
But in the UI I can still see an option for Secure Socks:
pkg/plugin/instance.go
Outdated
| datasourceSettings.CachingEnabled = true | ||
|
|
||
| instance, err := NewGitHubInstance(context.Background(), datasourceSettings) | ||
| instance, err := NewGitHubInstance(context.Background(), datasourceSettings, opts) |
Member
There was a problem hiding this comment.
Do you know perhaps why we don't pass down the context from the NewDataSourceInstance?
Author
There was a problem hiding this comment.
I am honestly not quite sure why we create a new separate "immortal" context.
I changed this to use the ctx from NewDatasourceInstance and it all seemed to work as expected?
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
…tasource into jck/enable-pdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PDC on the GitHub datasource:
I tested using: https://wiki.grafana-ops.net/w/index.php/Engineering/Grafana/Data_Sources/API_servers/Testing_datasources_with_PDC_Locally.
Confirmed that after enabling PDC, and the secure socks proxy toggle, I could see logs coming from the Agent. Similarly when I turned the agent off, I could see queries begin to fail.
Fixes #120